Optional fallback option#125
Open
vtsybulin wants to merge 2 commits into
Open
Conversation
…case CacheManager fails to download the main image with, error response code different from 200. Fallback should be provided as a local asset module.
vtsybulin
changed the title
Author
|
@wcandillon Hi. Any feedback on this? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional fallback option in case CacheManager fails to download the main image with error response code different from 200. Fallback should be provided as a local asset module.
@wcandillon Hi there. Thanks for the awesome plugin! Being using it a lot. However, for the current project, I faced an issue: when the image URL is broken or there is a network issue, blurry preview keeps hanging forever. I thought would be good to be able to fall back to some default thumbnail in this case.
Let me know what you think. Thanks
Example of usage:
const fallback = require('...');
...
<Image {...{ preview, uri }} fallback={fallback} />